Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GN-4825: Fix fetching snippets from RB #658

Merged
merged 2 commits into from
May 17, 2024
Merged

GN-4825: Fix fetching snippets from RB #658

merged 2 commits into from
May 17, 2024

Conversation

dkozickis
Copy link
Contributor

@dkozickis dkozickis commented May 13, 2024 •
edited
Loading

Overview

GN-4825: Fix fetching snippets from RB

  • Use RDFA aware SnippetInsertComponent and SnippetListSelectComponent

Previously pressing on "Insert snippet" did not show any snippets because there were no snippets assigned.

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4825

Setup

  1. Checkout

How to test/reproduce

CleanShot.2024-05-13.at.10.21.55.mp4

Challenges/uncertainties

Should "Manage snippet lists" button be in GN?

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@abeforgit
Copy link
Member

Should "Manage snippet lists" button be in GN?

no, and this pr's a good spot to remove it

abeforgit
abeforgit requested changes May 13, 2024
View reviewed changes
Copy link
Member

@abeforgit abeforgit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as well as the other comment, could you replace the default RB environment config in environment.js to the dev env as well please? forgot to do that when releasing, it's still connected to futurenow

(pr ok to merge when these are done)

@dkozickis
Copy link
Contributor Author

could you replace the default RB environment config in environment.js to the dev env as well please? forgot to do that when releasing, it's still connected to futurenow

Done 🙏🏻

@dkozickis dkozickis enabled auto-merge May 17, 2024 13:13
@dkozickis dkozickis merged commit 512efab into master May 17, 2024
3 checks passed
@dkozickis dkozickis deleted the GN-4825 branch May 17, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeforgit abeforgit abeforgit approved these changes

@piemonkey piemonkey Awaiting requested review from piemonkey

@lagartoverde lagartoverde Awaiting requested review from lagartoverde

@elpoelma elpoelma Awaiting requested review from elpoelma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkozickis @abeforgit